Skip to content

Make column and line non-optional #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 13, 2023

Fixes #1525

@kimdv kimdv force-pushed the kimdv/remove-ComputedLocation branch from 7b7d57d to 1f5d2c2 Compare April 13, 2023 07:17
@kimdv
Copy link
Contributor Author

kimdv commented Apr 13, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 13, 2023

swiftlang/swift#65141

@swift-ci please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

kimdv added a commit to kimdv/swift that referenced this pull request Apr 14, 2023
@kimdv kimdv force-pushed the kimdv/remove-ComputedLocation branch from 1f5d2c2 to 131fadd Compare April 14, 2023 08:45
@kimdv
Copy link
Contributor Author

kimdv commented Apr 14, 2023

swiftlang/swift#65141

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 14, 2023

kimdv added a commit to kimdv/swift-format that referenced this pull request Apr 14, 2023
@kimdv
Copy link
Contributor Author

kimdv commented Apr 14, 2023

kimdv added a commit to kimdv/swift-stress-tester that referenced this pull request Apr 14, 2023
kimdv added a commit to kimdv/swift-format that referenced this pull request Apr 14, 2023
@kimdv
Copy link
Contributor Author

kimdv commented Apr 14, 2023

kimdv added a commit to kimdv/swift-stress-tester that referenced this pull request Apr 14, 2023
@kimdv
Copy link
Contributor Author

kimdv commented Apr 14, 2023

kimdv added a commit to kimdv/swift that referenced this pull request Apr 18, 2023
kimdv added a commit to kimdv/swift-format that referenced this pull request Apr 18, 2023
kimdv added a commit to kimdv/swift-stress-tester that referenced this pull request Apr 18, 2023
@kimdv kimdv force-pushed the kimdv/remove-ComputedLocation branch from 131fadd to 181c6e8 Compare April 18, 2023 19:38
@kimdv
Copy link
Contributor Author

kimdv commented Apr 18, 2023

@kimdv
Copy link
Contributor Author

kimdv commented Apr 18, 2023

kimdv added a commit to kimdv/swift that referenced this pull request Apr 18, 2023
kimdv added a commit to kimdv/swift-stress-tester that referenced this pull request Apr 19, 2023
@kimdv
Copy link
Contributor Author

kimdv commented Apr 19, 2023

kimdv added a commit to kimdv/swift-stress-tester that referenced this pull request Apr 19, 2023
@kimdv
Copy link
Contributor Author

kimdv commented Apr 19, 2023

kimdv added a commit to kimdv/swift that referenced this pull request Apr 19, 2023
@kimdv
Copy link
Contributor Author

kimdv commented Apr 19, 2023

@kimdv
Copy link
Contributor Author

kimdv commented Apr 19, 2023

kimdv added a commit to kimdv/swift-stress-tester that referenced this pull request Apr 20, 2023
kimdv added a commit to kimdv/swift that referenced this pull request Apr 20, 2023
@kimdv kimdv force-pushed the kimdv/remove-ComputedLocation branch from 181c6e8 to 0f1666e Compare April 20, 2023 06:22
@kimdv
Copy link
Contributor Author

kimdv commented Apr 20, 2023

@kimdv
Copy link
Contributor Author

kimdv commented Apr 20, 2023

@kimdv kimdv merged commit 40fe88f into swiftlang:main Apr 20, 2023
@kimdv kimdv deleted the kimdv/remove-ComputedLocation branch April 20, 2023 15:46
kimdv added a commit to kimdv/swift that referenced this pull request Apr 20, 2023
kimdv added a commit to kimdv/swift-syntax that referenced this pull request Apr 20, 2023
kimdv added a commit to kimdv/swift that referenced this pull request May 18, 2023
kimdv added a commit to kimdv/swift-syntax that referenced this pull request May 18, 2023
kimdv added a commit to kimdv/swift that referenced this pull request May 21, 2023
kimdv added a commit to kimdv/swift that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceLocation should not have an optional line and column
2 participants